billing: Improve performance by using prefix rollups, and more #2387
+283
−172
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| tracing::warn!( | ||
| ?has_payment_method, | ||
| stripe_payment_method = real_default_payment_method.is_some(), | ||
| "Inconsistent payment method state" |
Member
There was a problem hiding this comment.
q: does this log in practice?
Contributor
Author
There was a problem hiding this comment.
Yep! Our stripe capture sometimes doesn't keep up, or something. I haven't looked too deeply into it. It didn't log at all this most recent time running billing, but previously it logged quite a lot.
…e with `auto_advance`. Also add `--fix_auto_advance`, and detect+send `manual` invoices for the target month as well
jshearer
force-pushed
the
stripe/invoice_gen_faster
branch
from
5f3055c to
ece937c
Compare
`has_full_pipeline`
jshearer
force-pushed
the
stripe/invoice_gen_faster
branch
from
ece937c to
87d38e7
Compare
Contributor
Author
|
@jgraettinger ping |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
NoDataMovedorNoFullPipelineif the customer also does not have a payment method on file. If a customer had billable usage, but then deleted all of their captures or materializations, they wouldn't have gotten an invoice prior to this change. If they have a payment method on file, we can and should bill for this legitimate usage.catalog_stats_monthlytable with exact tenant matching for improved query performancedate_startto only include those beginning within the target monthauto_advance=trueduring invoice finalization, allowing Stripe to handle automatic charging and retries