Add connector status overview to entity details page #1535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kiahna-tucker
commented
Mar 26, 2025
There was a problem hiding this comment.
This logic is bound to change and, more or less, functions as a placeholder. According to Phil, a null connector_status could be indicative of one of three things:
-
A connector status has not come through yet.
-
The task is not working.
-
The ops catalog is not working.
There was a problem hiding this comment.
Can you toss this into the code as a comment?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
The issues directly below are completely resolved by this PR:
#1519
Changes
1519
The following features are included in this PR:
Add connector overview card to the Status section of the Logs tab on an entity details page.
Extend the control-plane
/statusendpoint interfaces to update/include those related toconnector_status.Tests
Manually tested
Approaches to testing are as follows:
Validate that the connector status overview card displays as expected when the control-plane
/statusendpoint returns aconnector_statusobject.Validate that the connector status overview card displays as expected when the control-plane
/statusendpoint returns a nullconnector_status.Automated tests
N/A
Playwright tests ran locally
Screenshots
No
connector_statusreturned by control-plane/statusendpointA
connector_statusis returned by control-plane/statusendpoint