Hide redundant Page Size buttons

[enkodellc]

Add logic to show only page size if the row count is greater than the count and less than the next count button.

[enkodellc]

Sorry got a typo in my first commit. Either way TravisCI passed but CicleCI didn't? I followed the contribution guidelines. Not sure what else to do. Admin please let me know.

[christianacca]

There some overlap between this pull request and #656

Lots of good ideas. However, hiding page size buttons is probably not suitable in every situation.

As explained in the the other pull request, we might need to introduce a new option:

.. it could be a good time to consolidate the existing options determining how the pager is displayed. Once consolidated they would have more "room to grow".

Also, what I think is also important is not to load up on options as this can make it harder to work with the library.

Alternative solution:

1. make it easier to create custom pager templates; AND/OR
2. create another template, possibly 2 that will cover the main variations that apps require

[christianacca]

There's a pull request to implement infinite scroll (#560)

As commented:

... separate out pager options and page generation logic from NgTableParams
... someone to take the lead on this

[christianacca]

So looks like we have a bunch of options for pagination: #556, #555, #648 (this one), #656, #560, #454

[enkodellc]

@christianacca I like your ideas you posted on #656 did you want to assign anyone to start doing those PR's? I am willing to do some work to join these PR's if you are willing to give me some support to get them done to be merged.

[christianacca]

Cool. When do you want to start on this? The first thing is to do the consolidation work:

Pull request 1 - refactor pagination settings (#656)

I'll can do a quick peer review and merge.

If you still got time, we can get onto the enhancements. If you stop there, your contribution will still be of benefit to the project.

C

[enkodellc]

Ok I will look into the refactor for the pagination settings. Should I refactor for the current settings to start and then do additional PR's when adding features or should I include some of those settings right off the get go.

[christianacca]

Let's keep the refactoring into a separate PR

[enkodellc]

I just submitted a separate PR. #674

[christianacca]

Yup, just merging it with some stuff I've just pushed. Also, I'm got a couple of small feedback items around the commit