feat(es_extended/client/imports/point.lua): Merge module into imports#1612
Closed
feelfreetofee wants to merge 7 commits intoesx-framework:devfrom
Closed
feat(es_extended/client/imports/point.lua): Merge module into imports#1612feelfreetofee wants to merge 7 commits intoesx-framework:devfrom
feelfreetofee wants to merge 7 commits intoesx-framework:devfrom
Conversation
The point module now only runs in the script that uses it
now the module is exclusively imported
Removed since the core is not related to the module anymore
…layer coordinates The code was using ```PlayerObject:GetCoords()``` when it should be ```GetEntityCoords(ESX.PlayerData.ped)```
Mycroft-Studios
suggested changes
Feb 16, 2025
- Corrected the usage of "ESX.Table.SizeOf" - Added argument to Wait - remove unused and repeated loop variable "handle" - renamed loop variable "point" to "nearbyPoints" since there's already a point variable in the closure - Removed trailing space
I do this mainly for the linter, a single space doesn't scare me
The file doesn't exist anymore
Contributor
|
As discussed, this will become obsolete with the next update. I'm really sorry for the time that has been dedicated for this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The module is now exclusively imported.
Motivation
The development team has chosen to restrict the module's scope to the importing resource
Implementation Details
I have implemented two separate threads to manage point detection efficiently:
Main Thread:
Nearby Thread:
This setup ensures that the main thread runs intermittently to save resources, only activating when necessary.
The nearby thread runs at full speed only when the player is near relevant points, ensuring responsive interactions.
Usage Example
PR Checklist