Skip to content

refactor(es_extended): use cached ped#1627

Closed
Mirrrrrow wants to merge 1 commit intoesx-framework:ox-libfrom
Mirrrrrow:ox-lib
Closed

refactor(es_extended): use cached ped#1627
Mirrrrrow wants to merge 1 commit intoesx-framework:ox-libfrom
Mirrrrrow:ox-lib

Conversation

@Mirrrrrow
Copy link
Copy Markdown
Contributor

@Mirrrrrow Mirrrrrow commented Mar 31, 2025

Description

Uses ox_libs cache.ped instead of PlayerPedId() or ESX.PlayerData.Ped.


Motivation

As ox_lib got added in this branche, why not use their cache (e.g ped).


Implementation Details

Just replaced the call where it was needed.


Usage Example

/


PR Checklist

  • My commit messages and PR title follow the Conventional Commits standard.
  • [] My changes have been tested locally and function as expected.
  • My PR does not introduce any breaking changes.
  • I have provided a clear explanation of what my PR does, including the reasoning behind the changes and any relevant context.

Used ox_libs `cache.ped` instead of `PlayerPedId()` or `ESX.PlayerData.Ped`.
@github-project-automation github-project-automation bot moved this to 🆕 To be Discussed in ESX Roadmap Mar 31, 2025
@Kenshiin13
Copy link
Copy Markdown
Contributor

Hey @Mirrrrrow,
while I appreciate your contribution, this branch is a work in progress. The entire codebase will be refactored. We didn't forget to use the lib cache in your proposed changes, we just haven't gotten to it yet. Due to the nature of this branch and what we have planned for it, we don't believe it's suitable for PRs at its current stage.

Any contributions to the dev branch are welcome though!

@Kenshiin13 Kenshiin13 closed this Mar 31, 2025
@github-project-automation github-project-automation bot moved this from 🆕 To be Discussed to Recycle Bin in ESX Roadmap Mar 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Recycle Bin

Development

Successfully merging this pull request may close these issues.

3 participants