Identity age validation#1632
Merged
Kenshiin13 merged 9 commits intoesx-framework:devfrom May 20, 2025
Merged
Conversation
4 tasks
Kenshiin13
requested changes
May 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR refactors the age validation logic. It replaces the previous
LowestYearandHighestYearwithMinAgeandMaxAge, making the age validation more dynamic and easier to configure. The logic now calculates the minimum and maximum valid birth years based on the current year and the configuredMinAgeandMaxAge.Motivation
This PR was inspired by #1626 Pull Request, where a recent change only adjusted the
MinYearconfiguration value. Rather than continuing with static year values, I aimed to provide a more flexible solution by introducing age-based configuration. This allows users to specify the age range directly, making it clearer and easier to manage, especially when maintaining the age validation across multiple versions.Implementation Details
Config.LowestYearandConfig.HighestYearhave been replaced byConfig.MinAgeandConfig.MaxAgein the main config file.checkDOBFormatfunction has been updated to dynamically calculate the valid birth years based on the current year and the configuredMinAgeandMaxAgeThis refactor improves clarity, flexbility and scalability, allowing the age range to be updated without changing hardcoded year values.
Usage Example
Now, instead of adjusting the
LowestYearandHighestYear, users can directly specify the minimum and maximum ages.PR Checklist