refactor(esx_notify): redesign, code improvements.#1635
Merged
Kenshiin13 merged 5 commits intoesx-framework:devfrom May 9, 2025
Merged
refactor(esx_notify): redesign, code improvements.#1635Kenshiin13 merged 5 commits intoesx-framework:devfrom
Kenshiin13 merged 5 commits intoesx-framework:devfrom
Conversation
Kenshiin13
requested changes
May 8, 2025
github-project-automation
bot
moved this from 🆕 To be Discussed
to In-Development
in ESX Roadmap
github-project-automation
bot
moved this from In-Development
to Ready for Next Update
in ESX Roadmap
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
It revamps the current design ox esx_notify v1.12.4, it re-tweaks minor parts of the lua code, adds an extra "Title" Parameter to use from now on ( its optional ). It now has soundFX using oscillators for the notification pop ups. I improved the code structure in app.js, and added a sanitization function to sanitize any possible malicious injections.
Motivation
Old notifications were too blant and quite ugly honestly.
Implementation Details
It improves overall design, and its better looking , rather than an old blant and simple look, it enhances it quite a bit.
Usage Example
-- With title (optional 4th parameter)
ESX.ShowNotification("message here", "success", 3000, "Achievement")
PR Checklist