(fix): failed to reconnect after client crashed#1640
Merged
Kenshiin13 merged 24 commits intoesx-framework:devfrom Jun 15, 2025
Merged
(fix): failed to reconnect after client crashed#1640Kenshiin13 merged 24 commits intoesx-framework:devfrom
Kenshiin13 merged 24 commits intoesx-framework:devfrom
Conversation
Kenshiin13
requested changes
May 20, 2025
github-project-automation
bot
moved this from 🆕 To be Discussed
to In-Development
in ESX Roadmap
…r unloading players stale
…rCrashed' for consistency
…ta removing logic
…up stale player obj
Kenshiin13
previously approved these changes
Jun 14, 2025
Mycroft-Studios
previously approved these changes
Jun 15, 2025
github-project-automation
bot
moved this from In-Development
to Ready for Next Update
in ESX Roadmap
Mycroft-Studios
approved these changes
Jun 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixed failed to reconnecting after clients crashed, by validate if
player id/sourcebefore connecting.Motivation
The original validation for connecting logic just validate if
ESX.GetPlayerFromIdentifieris in used, so when clients crashed, theplayerDroppedevent isn't properly triggered and make the reconnecting failed.Implementation Details
no new or modifies existing exposed functionality
Usage Example
PR Checklist