Skip to content

refactor(es_extended/server/class/player): add proper type annotations#1704

Merged
Kenshiin13 merged 4 commits intodevfrom
player-class
Aug 17, 2025
Merged

refactor(es_extended/server/class/player): add proper type annotations#1704
Kenshiin13 merged 4 commits intodevfrom
player-class

Conversation

@Kenshiin13
Copy link
Copy Markdown
Contributor

@Kenshiin13 Kenshiin13 commented Aug 16, 2025

Description

This PR adds proper type annotations for the xPlayer class, including all properties and methods. Each function now has clearly defined parameter and return types, improving type safety and editor autocomplete support for developers using the class.


Motivation

Adding type annotations helps prevent runtime errors, improves code readability, and provides better support for IDEs with type checking and IntelliSense. This change directly resulted in multiple warnings in the codebase which would have resulted in unexpected behaviour or errors.


PR Checklist

  • My commit messages and PR title follow the Conventional Commits standard.
  • My changes have been tested locally and function as expected.
  • My PR does not introduce any breaking changes.
  • I have provided a clear explanation of what my PR does, including the reasoning behind the changes and any relevant context.

@Kenshiin13 Kenshiin13 changed the title Player class refactor(es_extended/server/class/player): add proper type annotations Aug 16, 2025
Copy link
Copy Markdown
Contributor

@Zykem Zykem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Kenshiin13 Kenshiin13 merged commit a9ae0b4 into dev Aug 17, 2025
3 checks passed
@Kenshiin13 Kenshiin13 deleted the player-class branch August 17, 2025 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants