refactor(es_extended/server/class/player): add proper type annotations#1704
Merged
Kenshiin13 merged 4 commits intodevfrom Aug 17, 2025
Merged
refactor(es_extended/server/class/player): add proper type annotations#1704Kenshiin13 merged 4 commits intodevfrom
Kenshiin13 merged 4 commits intodevfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds proper type annotations for the
xPlayerclass, including all properties and methods. Each function now has clearly defined parameter and return types, improving type safety and editor autocomplete support for developers using the class.Motivation
Adding type annotations helps prevent runtime errors, improves code readability, and provides better support for IDEs with type checking and IntelliSense. This change directly resulted in multiple warnings in the codebase which would have resulted in unexpected behaviour or errors.
PR Checklist