refactor(esx_identity): use static player methods#1708
Conversation
Kenshiin13
requested changes
Aug 23, 2025
| Wait(0) | ||
| end | ||
|
|
||
| local xPlayers = ESX.GetExtendedPlayers() |
Contributor
There was a problem hiding this comment.
Each static xPlayer is passed as an arg to the checkIdentity function. In that function it attempts to access player properties, which is not possible with static xPlayers. The function has to be refactored, it won't work like this.
Kenshiin13
changed the title
Static player object
Kenshiin13
requested changes
Aug 27, 2025
Contributor
Kenshiin13
left a comment
Kenshiin13
left a comment
There was a problem hiding this comment.
SetPlayerData still uses xPlayer.source
Kenshiin13
requested changes
Aug 27, 2025
xPlayer.getSource() to xPlayer.src
Contributor
|
Already done |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add static ESX.ExtendedPlayers
Update main.lua