add a new argument on the register command feature#1715
Merged
Kenshiin13 merged 7 commits intodevfrom Aug 31, 2025
Merged
Conversation
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces per-argument validation support in
ESX.RegisterCommand.It allows developers to define an
isValidfunction (and optional error message) directly inside each argument definition, enabling more granular control and safer command usage.As an example, the
/giveitemcommand now enforces that thecountargument must be a positive number.Motivation
Previously, command validation in ESX was limited:
number,string,player, etc.) was enforced.This led to duplicated logic across commands and inconsistent error handling.
By adding
isValidsupport, validation becomes declarative, reusable, and consistent across the framework.Implementation Details
Updated the argument parsing logic inside
ESX.RegisterCommand:newArgs[v.name]) is passed intov.isValid.pcallis used to protect against errors inside the validator function.v.error, otherwise a generic localized error is used.Backwards compatibility is maintained:
isValidcontinue to work.Usage Example
PR Checklist