fix(cron): resolve task execution conflicts and timing precision issues#1718
Closed
DyroS3 wants to merge 30 commits intoesx-framework:devfrom
Closed
fix(cron): resolve task execution conflicts and timing precision issues#1718DyroS3 wants to merge 30 commits intoesx-framework:devfrom
DyroS3 wants to merge 30 commits intoesx-framework:devfrom
Conversation
This reverts commit 45308f5.
Apparently, passing leading nil values via an export breaks it entirely.
feat: add auto-migrations on startup
…ment-isValid-on-register-command add a new argument on the register command feature
feat(esx_menu_default) Redesign of the menu.
fix(esx_menu_default): remove debug print
…absolute units with vh
feat(esx_menu_dialog) Updates the UI of esx_menu_dialog to match esx_menu_default
Fixed critical bugs in cron system causing scheduled tasks to fail after server restarts.
Contributor
Author
|
This submission is intended to resolve this issue. #1294 |
Kr3mu
reviewed
Sep 2, 2025
Member
Kr3mu
left a comment
There was a problem hiding this comment.
lgtm, but I'll test it when I get home and if everything is alright I'll approve it.
Member
|
Hey, reviewed your code once again when I came back from school, looks good to me. I like what you did, but I'll told kenshin to also verify this change. Thanks for opening the PR. |
|
|
Member
|
New cron will be in esx_lib |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(cron): resolve task execution conflicts and timing precision issues
Description
Fixed critical bugs in cron system causing scheduled tasks to fail after server restarts.
Motivation
When servers restarted before scheduled task times (e.g., server restarts at 19:10, task scheduled for 19:20), cron jobs would not execute. This affected resources like okokDeleteVehicles that depend on scheduled cleanup tasks.
Root Causes:
lastTimestamp, causing interferenceImplementation Details
Per-task execution tracking:
lastRuntimestamp for each cron jobPrecision minute-boundary timing:
Enhanced validation:
Usage Example
PR Checklist