Skip to content

fix(web): display correct gender#1721

Merged
Zykem merged 1 commit intoesx-framework:devfrom
Mirrrrrow:dev
Sep 13, 2025
Merged

fix(web): display correct gender#1721
Zykem merged 1 commit intoesx-framework:devfrom
Mirrrrrow:dev

Conversation

@Mirrrrrow
Copy link
Copy Markdown
Contributor

@Mirrrrrow Mirrrrrow commented Sep 4, 2025

Description

This PR fixes a bug where the gender of the character wasn't displayed correctly.


Motivation

Fixes #1713.


Implementation Details

Removed a check in the Frontend that tried to generate the gender label, however it was already done in the backend when fetching the characters.


PR Checklist

  • My commit messages and PR title follow the Conventional Commits standard.
  • My changes have been tested locally and function as expected.
  • My PR does not introduce any breaking changes.
  • I have provided a clear explanation of what my PR does, including the reasoning behind the changes and any relevant context.

Copy link
Copy Markdown
Contributor

@Zykem Zykem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on my side, LGTM!

@CtFatalv
Copy link
Copy Markdown

CtFatalv commented Sep 8, 2025

Perfect ty

@Zykem Zykem merged commit fa6f63a into esx-framework:dev Sep 13, 2025
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants