Improve AF compatibility across different camera HAL implementations and Implement independent AF/AE metering and draggable indicators - #181
Open
matthew777777 wants to merge 1 commit into
Conversation
- Add separate draggable exposure indicator with a sun icon. - Coordinate independent AF and AE metering points in `TouchFocus`. - Refine AF/AE trigger logic in `CaptureController` to prevent redundant restarts and improve HAL compatibility. - Update coordinate mapping to use `SENSOR_INFO_ACTIVE_ARRAY_SIZE` and fix viewfinder-to-sensor translation. - Apply manual focus distance to still capture requests. - Improve focus range and hyperfocal distance handling in `CameraProperties`. - Update AF state labels and constants in the UI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR improves the camera focus and exposure controls by separating AF and AE metering, correcting coordinate mapping, refining capture-request behavior, and improving manual-focus handling.
Changes
TouchFocusto coordinate independent AF and AE metering points.CaptureControllerto:SENSOR_INFO_ACTIVE_ARRAY_SIZE.CameraProperties, including more reliable behavior when camera metadata is incomplete or device-specific.Result
AF and AE can now be controlled independently and positioned more accurately. Manual focus is preserved during still capture, focus-distance calculations are more robust, and the updated trigger logic reduces unnecessary focus restarts while improving compatibility across devices.