fix(chunk): fix unexisting get_document_chunk call#782
Merged
leoguillaume merged 1 commit intoMar 17, 2026
Conversation
leoguillaume
approved these changes
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes a 500 error on GET /v1/documents/{document_id}/chunks/{chunk_id} caused by a call to a non-existent method get_document_chunk on the document manager. The correct method is get_document_chunks (plural).
The argument order was also adjusted to match the method's signature.
Resolves #781.
Overview
This section provides a checklist to help categorize and describe the changes made in this PR.
Area
Please select the area(s) that this PR affects:
Type of change
Please select the type of change that this PR introduces:
Definition of Done / Technical changes
Please provide the Definition of Done (DoD) criteria that apply to this PR.
Screenshots / Demo (if applicable)
For more screenshots, please refer to #781.
Breaking changes
Please select one of the following options:
Quality assurance & Review readiness
Before requesting a review, please take a moment to confirm that the following aspects have been considered and addressed.
This section helps ensure the PR is ready for review, safe to merge, and deployable. If any items are left unchecked, please add a brief explanation for context.
Documentation
Please select one of the following options:
Tests
Please select one or more of the following options:
The fix is a one-line method name correction - no new logic introduced. Existing integration tests covering this endpoint should be sufficient. Also, tests are completely nder clean architecture migration. This branch is just a quick fix.
Code Standards
Git & Process Standards
Deployment Notes
Database migration
Please select one of the following options:
Please confirm that the following steps have been completed for the database migration:
api/alembic/versions/folderReviewer Focus
Single-line fix in api/endpoints/documents.py:250 — verify the correct method name and that the argument order matches get_document_chunks's signature.