[DRAFT] Suite suppression "compile time env"#5556
Draft
thbar wants to merge 3 commits into
Draft
Conversation
Contributor
Author
|
@etalab/transport-tech je déploie sur prochainement. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dans cette PR, je continue le travail suivant:
Je remplace
prod.exs(qui embarque des variables d'ENV à la compilation) par un mécanisme de génération de configuration.Un module est compilé, qui prend en entrée une map et l'atome de l'environnement (ici
:prod). Par conséquent, les tests peuvent vérifier que la configuration de prod est correcte.Le runtime se contente d'appeler 1 méthode de ce module (et là, si des variables manquent, au cas par cas c'est une exception qui est levée).
J'ouvre pour qu'on puisse regarder un peu, toutefois vu la surface, je testerai sur prochainement et vérifierai que la config est identique via SSH, avant/après.
Etapes
J'ai commencé par ré-activer le check credo correspondant sur
prod.exs, qui a montré les warnings suivants:Puis j'ai corrigé.