Bump min cmake version to 3.10 (from 3.3) - #154
Merged
Merged
Conversation
Current cmake is at least 3.25.1 (or later) in Linux distributions, and some recent ones (e.g. on Ubuntu 24.04) produce warnings when they see a specification of such an ancient min cmake version. This PR silences these warnings.
davidklaftenegger
approved these changes
Sep 18, 2025
davidklaftenegger
left a comment
davidklaftenegger
left a comment
Member
There was a problem hiding this comment.
trivial change, obviously better than status quo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current cmake is at least 3.25.1 (or later) in Linux distributions, and some recent ones (e.g. on Ubuntu 24.04) produce warnings when they see a specification of such an ancient min cmake version.
This PR silences these warnings.