Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump go 1.24.0 #208

Merged
merged 1 commit into from
Feb 25, 2025
Merged

Bump go 1.24.0 #208

merged 1 commit into from
Feb 25, 2025

Conversation

Elbehery
Copy link
Member

@Elbehery
Copy link
Member Author

/assign @ivanvc
/assign @henrybear327


toolchain go1.23.6
toolchain go1.24.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Elbehery can you please rebase following merge of #209

@Elbehery
Copy link
Member Author

the error still the same

 Running [/home/runner/golangci-lint-1.63.4-linux-amd64/golangci-lint run  --config tools/.golangci.yaml] in [/home/runner/work/auger/auger] ...
  Error: can't load config: the Go language version (go1.23) used to build golangci-lint is lower than the targeted Go version (1.24.0)
  Failed executing command with error: can't load config: the Go language version (go1.23) used to build golangci-lint is lower than the targeted Go version (1.24.0)

I bumped the linter to the most recent version iiuc 🤔

@Elbehery
Copy link
Member Author

@ahrtr we need similar bump here

etcd-io/bbolt#911 (comment)

@ivanvc ivanvc mentioned this pull request Feb 18, 2025
16 tasks
@siyuanfoundation
Copy link
Contributor

/retest

@Elbehery
Copy link
Member Author

@siyuanfoundation thanks tons

we need to fix the linter issue :'(

@ivanvc
Copy link
Member

ivanvc commented Feb 20, 2025

@Elbehery, I had a big backlog of notifications, and I'm just looking at this. I think #209 should have updated the golangci-lint action to use golangci-lint 1.64.5. That may be the reason why this is failing.

Edit: I tested this locally with 1.64.5 and it works. Refer to etcd-io/raft#268 (comment)

@Elbehery
Copy link
Member Author

@Elbehery, I had a big backlog of notifications, and I'm just looking at this. I think #209 should have updated the golangci-lint action to use golangci-lint 1.64.5. That may be the reason why this is failing.

Edit: I tested this locally with 1.64.5 and it works. Refer to etcd-io/raft#268 (comment)

raised #216

@Elbehery
Copy link
Member Author

/assign @ahrtr

Signed-off-by: Mustafa Elbehery <[email protected]>
@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Elbehery, siyuanfoundation

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@siyuanfoundation siyuanfoundation merged commit 3863d4b into etcd-io:main Feb 25, 2025
3 checks passed
@ivanvc
Copy link
Member

ivanvc commented Feb 25, 2025

🎉 🎉 Thanks, @Elbehery.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants