-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump go 1.24.0 #208
Bump go 1.24.0 #208
Conversation
/assign @ivanvc |
|
||
toolchain go1.23.6 | ||
toolchain go1.24.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the error still the same
I bumped the linter to the most recent version iiuc 🤔 |
@ahrtr we need similar bump here |
/retest |
@siyuanfoundation thanks tons we need to fix the linter issue :'( |
@Elbehery, I had a big backlog of notifications, and I'm just looking at this. I think #209 should have updated the golangci-lint action to use golangci-lint 1.64.5. That may be the reason why this is failing. Edit: I tested this locally with 1.64.5 and it works. Refer to etcd-io/raft#268 (comment) |
raised #216 |
/assign @ahrtr |
Signed-off-by: Mustafa Elbehery <[email protected]>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Elbehery, siyuanfoundation The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
🎉 🎉 Thanks, @Elbehery. |
ref etcd-io/etcd#19417