Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

github/workflows: re-enable GitHub ARM64 runners #917

Closed
wants to merge 2 commits into from
Closed

github/workflows: re-enable GitHub ARM64 runners #917

wants to merge 2 commits into from

Conversation

ivanvc
Copy link
Member

@ivanvc ivanvc commented Mar 6, 2025

Github recently launched ARM64 Linux runners. Because we're facing dead ends trying to run them in the Prow infra (kubernetes/test-infra#33737), it may even be more complicated to maintain. This should be a good option for the time being.

Part of #848

@ivanvc
Copy link
Member Author

ivanvc commented Mar 6, 2025

🤞 🤞 that the tests pass :)

@ivanvc ivanvc changed the title github/workflows: use ARM64 runners for robustness tests github/workflows: use GitHub ARM64 runners for robustness tests Mar 6, 2025
ahrtr
ahrtr approved these changes Mar 6, 2025
View reviewed changes
Copy link
Member

@ahrtr ahrtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @fuweid

@ahrtr
Copy link
Member

ahrtr commented Mar 6, 2025 

Test started today at 7:34 AM is still running after 2h57m3s. ([more info](https://prow.k8s.io/spyglass/lens/metadata/iframe?req=%7B%22artifacts%22%3A%5B%22prowjob.json%22%2C%22started.json%22%5D%2C%22index%22%3A0%2C%22src%22%3A%22gs%2Fkubernetes-ci-logs%2Fpr-logs%2Fpull%2Fetcd-io_bbolt%2F917%2Fpull-bbolt-test-4-cpu-arm64%2F1897551272760840192%22%7D&topURL=https%3A//prow.k8s.io/view/gs/kubernetes-ci-logs/pr-logs/pull/etcd-io_bbolt/917/pull-bbolt-test-4-cpu-arm64/1897551272760840192&lensIndex=0#))

@ivanvc
Copy link
Member Author

ivanvc commented Mar 6, 2025

@ahrtr, I think it would be better to migrate the tests back to GitHub altogether, as the ARM tests have been unstable in the Prow infrastructure. Thoughts?

@ahrtr
Copy link
Member

ahrtr commented Mar 6, 2025

@ahrtr, I think it would be better to migrate the tests back to GitHub altogether, as the ARM tests have been unstable in the Prow infrastructure. Thoughts?

OK.

@fuweid
Copy link
Member

fuweid commented Mar 6, 2025

It looks like we need to remove arm test from prow infra first.

@ahrtr
Copy link
Member

ahrtr commented Mar 6, 2025

It looks like we need to remove arm test from prow infra first.

YES.

@ivanvc
github/workflows: add ARM64 tests
e40f783 
Restore ARM64 test workflows. Remove the conditional to run only ARM
tests in the upstream repository, as GitHub ARM runners are now publicly
available.

Signed-off-by: Ivan Valdes <[email protected]>
@ivanvc ivanvc changed the title github/workflows: use GitHub ARM64 runners for robustness tests github/workflows: re-enable GitHub ARM64 runners Mar 7, 2025
@ivanvc
Copy link
Member Author

ivanvc commented Mar 7, 2025

I rescoped this pull request and I'm now restoring GitHub's ARM tests. I also opened kubernetes/test-infra#34468 to remove the Prow ARM64 jobs.

@ivanvc ivanvc requested review from ahrtr and fuweid March 7, 2025 06:05
fuweid
fuweid approved these changes Mar 7, 2025
View reviewed changes
Copy link
Member

@fuweid fuweid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, fuweid, ivanvc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ivanvc
Copy link
Member Author

ivanvc commented Mar 11, 2025

/retest

@ivanvc ivanvc closed this Mar 12, 2025
@ivanvc ivanvc reopened this Mar 12, 2025
@ivanvc
Copy link
Member Author

ivanvc commented Mar 12, 2025

I don't think this pull request will have green CI checks, even after I closed and reopened it, the old Prow jobs will show up.

I can close and start a new PR. Please let me know what you think.

@ahrtr
Copy link
Member

ahrtr commented Mar 12, 2025

I can close and start a new PR. Please let me know what you think.

yes, please try it out, thx

@ivanvc ivanvc closed this Mar 12, 2025
@ivanvc ivanvc mentioned this pull request Mar 12, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fuweid fuweid fuweid approved these changes

@ahrtr ahrtr Awaiting requested review from ahrtr

Assignees
No one assigned
Labels
approved size/M
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ivanvc @ahrtr @fuweid @k8s-ci-robot