-
Notifications
You must be signed in to change notification settings - Fork 664
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
github/workflows: re-enable GitHub ARM64 runners #917
github/workflows: re-enable GitHub ARM64 runners #917
Conversation
Signed-off-by: Ivan Valdes <[email protected]>
🤞 🤞 that the tests pass :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @fuweid
|
@ahrtr, I think it would be better to migrate the tests back to GitHub altogether, as the ARM tests have been unstable in the Prow infrastructure. Thoughts? |
OK. |
It looks like we need to remove arm test from prow infra first. |
YES. |
Restore ARM64 test workflows. Remove the conditional to run only ARM tests in the upstream repository, as GitHub ARM runners are now publicly available. Signed-off-by: Ivan Valdes <[email protected]>
I rescoped this pull request and I'm now restoring GitHub's ARM tests. I also opened kubernetes/test-infra#34468 to remove the Prow ARM64 jobs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahrtr, fuweid, ivanvc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
I don't think this pull request will have green CI checks, even after I closed and reopened it, the old Prow jobs will show up. I can close and start a new PR. Please let me know what you think. |
yes, please try it out, thx |
Github recently launched ARM64 Linux runners. Because we're facing dead ends trying to run them in the Prow infra (kubernetes/test-infra#33737), it may even be more complicated to maintain. This should be a good option for the time being.
Part of #848