-
Notifications
You must be signed in to change notification settings - Fork 711
[release-1.3] Bump Go to 1.23.9 #956
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
65d1ee7 to
a2ad862
Compare
90137e2 to
288af30
Compare
|
/retest |
|
@ivanvc hello ✋🏽 the linter is failing it is the same issue with #957 cc @ahrtr |
|
/retest |
3 similar comments
|
/retest |
|
/retest |
|
/retest |
|
@Elbehery, please address https://github.com/etcd-io/bbolt/actions/runs/14883551391/job/42624625496?pr=956. Thanks. |
Hi @ivanvc I have tried many times, I ran the linter locally, and no issue this is happening only on |
|
By please address, I'd like to know if you could fix the failure on Windows. Not just retrying the workflow, as it is apparent it is not a flake. If you don't have the capacity to work on this, we can reassign the task to someone else. Thanks. |
Signed-off-by: Mustafa Elbehery <[email protected]>
288af30 to
5adfcc7
Compare
ivanvc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. But, same comment as #957 (review).
Thanks, @Elbehery.
ahrtr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM & thx
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ahrtr, Elbehery The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Part of etcd-io/etcd#19866.
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.
cc @ivanvc