Skip to content

Conversation

@Elbehery
Copy link
Member

@Elbehery Elbehery commented May 7, 2025

@Elbehery Elbehery force-pushed the 20250507-bump-go-1.23.9 branch from 65d1ee7 to a2ad862 Compare May 7, 2025 12:37
@Elbehery Elbehery force-pushed the 20250507-bump-go-1.23.9 branch 2 times, most recently from 90137e2 to 288af30 Compare May 7, 2025 12:38
@Elbehery
Copy link
Member Author

Elbehery commented May 7, 2025

/retest

@ivanvc ivanvc mentioned this pull request May 7, 2025
20 tasks
@Elbehery
Copy link
Member Author

Elbehery commented May 8, 2025

@ivanvc hello ✋🏽

the linter is failing

Running [D:\a\_temp\68fc53bc-d135-4b2d-b500-62ff34ec1b60\golangci-lint-1.61.0-windows-amd64\golangci-lint run] in [D:\a\bbolt\bbolt] ...
  Error: level=error msg="[linters_context] typechecking error: D:\\a\\bbolt\\bbolt\\internal\\btesting\\btesting.go:119:12: db.Update undefined (type *DB has no field or method Update)"
  Error: level=error msg="[linters_context] typechecking error: D:\\a\\bbolt\\bbolt\\internal\\btesting\\btesting.go:158:13: db.Update undefined (type *DB has no field or method Update)"
  Error: level=error msg="[linters_context] typechecking error: D:\\a\\bbolt\\bbolt\\internal\\btesting\\btesting.go:181:12: db.View undefined (type *DB has no field or method View)"
  Error: level=error msg="[linters_context] typechecking error: D:\\a\\bbolt\\bbolt\\internal\\btesting\\btesting.go:190:17: db.Stats undefined (type *DB has no field or method Stats)"
  Error: level=error msg="[linters_context] typechecking error: D:\\a\\bbolt\\bbolt\\tx.go:10:2: could not import sync/atomic (-: could not load export data: internal error in importing 

it is the same issue with #957

cc @ahrtr

@Elbehery
Copy link
Member Author

Elbehery commented May 9, 2025

/retest

3 similar comments
@Elbehery
Copy link
Member Author

/retest

@Elbehery
Copy link
Member Author

/retest

@Elbehery
Copy link
Member Author

/retest

@ivanvc
Copy link
Member

ivanvc commented May 27, 2025

@Elbehery
Copy link
Member Author

@Elbehery, please address https://github.com/etcd-io/bbolt/actions/runs/14883551391/job/42624625496?pr=956. Thanks.

Hi @ivanvc

I have tried many times, I ran the linter locally, and no issue

this is happening only on Win

@ivanvc
Copy link
Member

ivanvc commented May 28, 2025

By please address, I'd like to know if you could fix the failure on Windows. Not just retrying the workflow, as it is apparent it is not a flake.

If you don't have the capacity to work on this, we can reassign the task to someone else.

Thanks.

Signed-off-by: Mustafa Elbehery <[email protected]>
@Elbehery Elbehery force-pushed the 20250507-bump-go-1.23.9 branch from 288af30 to 5adfcc7 Compare May 28, 2025 22:57
Copy link
Member

@ivanvc ivanvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. But, same comment as #957 (review).

Thanks, @Elbehery.

Copy link
Member

@ahrtr ahrtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM & thx

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ahrtr, Elbehery

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ahrtr ahrtr merged commit e8b1527 into etcd-io:release-1.3 May 29, 2025
10 checks passed
@Elbehery Elbehery deleted the 20250507-bump-go-1.23.9 branch May 29, 2025 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

4 participants