Compaction hash

[serathius]

Found a bug in compaction hash consistency check when there are multiple concurrent compaction it discards hashes from them.

Need to add a test.

[k8s-ci-robot]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[chaochn47]

Found a bug in compaction hash consistency check when there are multiple concurrent compaction it discards hashes from them.

Maybe I lack context on this, but isn't compaction is schedued in the store fifo queue so there are no concurrent compactions in theory.

etcd/server/mvcc/kvstore.go

Line 263 in eb9bfaa

s.fifoSched.Schedule(j)

Is it a correct understanding?

[serathius]

Is it a correct understanding?

From backend perspective yes, I meant from client perspective they can schedule multiple requests. They will be put into job queue and executed consecutively.

[k8s-ci-robot]

@serathius: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-etcd-unit-test-amd64	c87d197	link	true	/test pull-etcd-unit-test-amd64
pull-etcd-unit-test-arm64	c87d197	link	true	/test pull-etcd-unit-test-arm64

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 21 days if no further activity occurs. Thank you for your contributions.