Experiments with replacing index implementation of btree with key -> revisions with revision list of immutable trees
#18184
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Skipping CI for Draft Pull Request. |
serathius
force-pushed
the
index-immutable-tree
branch
from
7da0cf0 to
6838500
Compare
|
Tried the btree with copy: |
|
Looking at btree code, looks like adding fast counting should not be hard as it already includes intervals. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files
... and 192 files with indirect coverage changes @@ Coverage Diff @@
## main #18184 +/- ##
===========================================
- Coverage 68.84% 57.03% -11.82%
===========================================
Files 421 420 -1
Lines 35857 35604 -253
===========================================
- Hits 24686 20305 -4381
- Misses 9751 13865 +4114
- Partials 1420 1434 +14 Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
2 tasks
4 tasks
|
@serathius: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
serathius
force-pushed
the
index-immutable-tree
branch
from
6838500 to
615f20d
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: serathius The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
serathius
force-pushed
the
index-immutable-tree
branch
2 times, most recently
from
e03571c to
8674a56
Compare
Signed-off-by: Marek Siarkowicz <[email protected]>
serathius
force-pushed
the
index-immutable-tree
branch
from
8674a56 to
63c92d0
Compare
serathius
force-pushed
the
index-immutable-tree
branch
2 times, most recently
from
625b706 to
db3a652
Compare
Signed-off-by: Marek Siarkowicz <[email protected]>
serathius
force-pushed
the
index-immutable-tree
branch
from
db3a652 to
4d92c28
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently talked with Marcel from Cillium about his recent issue with etcd being overloaded with LIST with limit. Even with low limit, the list will range all the keys to count the total number of keys (not a great feature).
My idea was to improve performance of getting key count within range by using interval trees. For now I didn't managed to implement it as I have already started seeing issues finding a good implementation of immutable tree. For now I tried with AVL trees.
The results:
Pros:
Cons:
The main blocker for this approach is reducing the cost of Puts and improving the
Even if the idea doesn't stick I expect we can keep the benchmarks.