-
Notifications
You must be signed in to change notification settings - Fork 10.1k
Define a DLocker
interface for distributed locker
#18779
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahrtr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
e44ecfb
to
ae27db3
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files
... and 16 files with indirect coverage changes @@ Coverage Diff @@
## main #18779 +/- ##
==========================================
+ Coverage 68.74% 68.78% +0.04%
==========================================
Files 420 420
Lines 35512 35515 +3
==========================================
+ Hits 24411 24430 +19
+ Misses 9671 9659 -12
+ Partials 1430 1426 -4 Continue to review full report in Codecov by Sentry.
|
/test pull-etcd-verify I want to check if it was a flake in |
Also updated the contrib/lock example to demo how to use the DLocker Signed-off-by: Benjamin Wang <[email protected]>
/test pull-etcd-integration-1-cpu-amd64 |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@ahrtr: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Also updated the contrib/lock example to demo how to use the
DLocker
.For more background, please refer to the article by Martin Kleppmann.