release: release (undraft) GitHub release from release script

[ivanvc]

Release (updraft) GitHub release from the release script after creating it, avoiding the last manual step of this process. However, if the user answers no to the prompt, the script won't exit with a failure code, as it is still possible to manually release it.

I tested this in my fork, and it works as expected.

Part of #18604

Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.83%. Comparing base (ffb6ff9) to head (5279471).
Report is 50 commits behind head on main.

❗ Current head 5279471 differs from pull request most recent head cc0e439

Please upload reports for the commit cc0e439 to get more accurate results.

Additional details and impacted files

Files with missing lines	Coverage Δ
api/version/version.go	86.66% <ø> (ø)

... and 26 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #18886      +/-   ##
==========================================
- Coverage   68.84%   68.83%   -0.01%     
==========================================
  Files         421      421              
  Lines       35900    35900              
==========================================
- Hits        24716    24713       -3     
+ Misses       9762     9757       -5     
- Partials     1422     1430       +8     

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ffb6ff9...cc0e439. Read the comment docs.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[jmhbnz]

LGTM - Thanks @ivanvc

[jmhbnz]

I think with a bit more testing / confidence we can simply drop the publishing of the release in draft mode and 10 minute review prompt and simply publish the full release.

It was a really great milestone to see the script automatically creating the GitHub release for us today so let's just get a bit more confidence in the next round of releases and then revisit it :)

[ivanvc]

I agree. I was hesitant to add this change, but no matter what arguments I'd pass to gh create release, the draft release in the edit UI always has the "set as latest release" checkbox ticked. So, the workaround was to publish the release by editing it, while passing all the possible arguments.

[ivanvc]

I'm going to draft this PR then. We can revisit it when we feel confident about automating the release process.

[ivanvc]

I left this in place, as it follows the approach of the other steps.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ivanvc, jmhbnz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• scripts/OWNERS [ivanvc,jmhbnz]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ivanvc]

/test pull-etcd-unit-test-386

[ivanvc]

I'm parking this pull request again. I'm thinking that we can keep the draft release as we have now and release it using a GitHub action (after the released artifacts tests pass). Based on etcd-io/auger I know that we have the permissions to publish the release from an action.

[ivanvc]

Note: I'll need to automate checking if it's a pre-release or if we should mark it as a release. I think it is doable with the following logic:

Pre-release

If there's a pre-release identifier (i.e., -alpha.0 from v3.6.0-alpha.0), mark it as a pre-release.

Latest version

1. If the patch ends with 0 (i.e., 3.6.0), mark it as the latest release.
2. If not,
   1. Get the latest release gh release list --json isLatest,tagName --jq '.[] | select(.isLatest) | .tagName'
   2. If the combination of the major and minor is the same as the release in question (i.e., v3.6), mark it as the latest release.