tests: address bridge unexported return issue

[manthanguptaa]

Introducing a new Bridge interface to resolve bridge unexported return issue

Part of #18370.

[k8s-ci-robot]

Hi @manthanguptaa. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[manthanguptaa]

@ivanvc @jmhbnz requesting your review.

Also, I did push a signed commit but it still shows an unverified commit. I set up the GPG key for the same.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.76%. Comparing base (801dfc3) to head (0f6a30f).
Report is 155 commits behind head on main.

Additional details and impacted files

see 36 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #19105      +/-   ##
==========================================
- Coverage   68.77%   68.76%   -0.01%     
==========================================
  Files         420      420              
  Lines       35623    35640      +17     
==========================================
+ Hits        24498    24507       +9     
- Misses       9699     9705       +6     
- Partials     1426     1428       +2     

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 801dfc3...0f6a30f. Read the comment docs.

[manthanguptaa]

@ivanvc polite reminder to review this

[manthanguptaa]

@ivanvc can you please review this one? I hope to get this merged this week

[ivanvc]

/ok-to-test

[ivanvc]

While working on this linter rule, we have found several instances where the unexported struct does not implement an existing interface. @ahrtr, @serathius, do you have an opinion on creating a new interface vs. exporting the struct? Initially, I was leaning towards creating an interface, but now, for the sake of simplicity, exporting the interface makes more sense.

[ahrtr]

While working on this linter rule, we have found several instances where the unexported struct does not implement an existing interface. @ahrtr, @serathius, do you have an opinion on creating a new interface vs. exporting the struct? Initially, I was leaning towards creating an interface, but now, for the sake of simplicity, exporting the interface makes more sense.

Adding an interface looks good to me. One minor related comment, can we rename UnpauseConnections to "ResumeConnections" (can be in a separate PR)?

[ahrtr]

/retest

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, manthanguptaa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [ahrtr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ivanvc]

Adding an interface looks good to me. One minor related comment, can we rename UnpauseConnections to "ResumeConnections" (can be in a separate PR)?

Should we just rename or deprecate+rename as it is an exported function?

[ahrtr]

Should we just rename or deprecate+rename as it is an exported function?

I don't think we need to deprecate+rename; We just need to rename it directly,

• It's just a test code;
• It's only included in main (3.6) branch, and 3.6 hasn't been released yet.