-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: enable early-return and superfluous-else from revive #19152
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files
... and 24 files with indirect coverage changes @@ Coverage Diff @@
## main #19152 +/- ##
==========================================
- Coverage 68.76% 68.74% -0.02%
==========================================
Files 420 420
Lines 35650 35641 -9
==========================================
- Hits 24513 24500 -13
+ Misses 9714 9706 -8
- Partials 1423 1435 +12 Continue to review full report in Codecov by Sentry.
|
1180239
to
35d0e02
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahrtr, mmorel-35 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
f328a9f
to
8f37a26
Compare
Signed-off-by: Matthieu MOREL <[email protected]> Co-authored-by: Iván Valdés Castillo <[email protected]>
40e8073
to
10d7cea
Compare
Description
early-return: In Go it is idiomatic to minimize nesting statements, a typical example is to avoid if-then-else constructions.
superfluous-else: To improve the readability of code, it is recommended to reduce the indentation as much as possible. This rule highlights redundant else-blocks that can be eliminated from the code.