-
Notifications
You must be signed in to change notification settings - Fork 9.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: enable unnecessary-stmt rule from revive #19155
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files
... and 20 files with indirect coverage changes @@ Coverage Diff @@
## main #19155 +/- ##
==========================================
+ Coverage 68.81% 68.86% +0.05%
==========================================
Files 421 421
Lines 35901 35898 -3
==========================================
+ Hits 24705 24721 +16
+ Misses 9770 9750 -20
- Partials 1426 1427 +1 Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
57aec15
to
8202497
Compare
8202497
to
c41fdfd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - Thanks @mmorel-35
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jmhbnz, mmorel-35 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
c41fdfd
to
4dd86ec
Compare
97d5f31
to
f609141
Compare
f609141
to
27ef962
Compare
Signed-off-by: Matthieu MOREL <[email protected]>
27ef962
to
d0dda55
Compare
Description
unnecessary-stmt: This rule suggests to remove redundant statements like a break at the end of a case block, for improving the code's readability.