Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: enable unnecessary-stmt rule from revive #19155

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mmorel-35
Copy link
Contributor

Description

unnecessary-stmt: This rule suggests to remove redundant statements like a break at the end of a case block, for improving the code's readability.

Copy link

codecov bot commented Jan 9, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 68.86%. Comparing base (d0b8863) to head (d0dda55).

Files with missing lines Patch % Lines
server/etcdmain/etcd.go 0.00% 1 Missing ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
server/storage/wal/repair.go 55.35% <100.00%> (-0.79%) ⬇️
server/etcdmain/etcd.go 0.00% <0.00%> (ø)

... and 20 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #19155      +/-   ##
==========================================
+ Coverage   68.81%   68.86%   +0.05%     
==========================================
  Files         421      421              
  Lines       35901    35898       -3     
==========================================
+ Hits        24705    24721      +16     
+ Misses       9770     9750      -20     
- Partials     1426     1427       +1     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d0b8863...d0dda55. Read the comment docs.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mmorel-35 mmorel-35 force-pushed the revive/unnecessary-stmt branch from 57aec15 to 8202497 Compare January 15, 2025 19:44
@mmorel-35 mmorel-35 force-pushed the revive/unnecessary-stmt branch from 8202497 to c41fdfd Compare January 19, 2025 10:01
Copy link
Member

@jmhbnz jmhbnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks @mmorel-35

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jmhbnz, mmorel-35

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mmorel-35 mmorel-35 force-pushed the revive/unnecessary-stmt branch from c41fdfd to 4dd86ec Compare January 30, 2025 22:30
@mmorel-35 mmorel-35 closed this Feb 4, 2025
@mmorel-35 mmorel-35 deleted the revive/unnecessary-stmt branch February 4, 2025 08:59
@mmorel-35 mmorel-35 restored the revive/unnecessary-stmt branch February 4, 2025 09:00
@mmorel-35 mmorel-35 reopened this Feb 4, 2025
@mmorel-35 mmorel-35 force-pushed the revive/unnecessary-stmt branch 2 times, most recently from 97d5f31 to f609141 Compare February 11, 2025 21:05
@mmorel-35 mmorel-35 force-pushed the revive/unnecessary-stmt branch from f609141 to 27ef962 Compare March 1, 2025 07:36
@mmorel-35 mmorel-35 force-pushed the revive/unnecessary-stmt branch from 27ef962 to d0dda55 Compare March 9, 2025 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants