Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor refactor on the etcdutl migrate command #19207

Merged
merged 1 commit into from
Jan 16, 2025

Conversation

ahrtr
Copy link
Member

@ahrtr ahrtr commented Jan 16, 2025

Extracted from #19168

I did not change the functionality. Instead It just breaks down the existing (o *migrateOptions) Config() into two methods, moved some code into a separate method (c *migrateConfig) finalize().

It's to make the reviewing on #19168 easier.

cc @fuweid @ivanvc @jmhbnz @serathius

@ahrtr
Copy link
Member Author

ahrtr commented Jan 16, 2025

/test pull-etcd-unit-test-386

Copy link

codecov bot commented Jan 16, 2025

Codecov Report

Attention: Patch coverage is 0% with 20 lines in your changes missing coverage. Please review.

Project coverage is 68.83%. Comparing base (92673d1) to head (39ccd99).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
etcdutl/etcdutl/migrate_command.go 0.00% 20 Missing ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
etcdutl/etcdutl/migrate_command.go 0.00% <0.00%> (ø)

... and 21 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #19207      +/-   ##
==========================================
+ Coverage   68.79%   68.83%   +0.04%     
==========================================
  Files         420      420              
  Lines       35629    35635       +6     
==========================================
+ Hits        24510    24531      +21     
+ Misses       9700     9685      -15     
  Partials     1419     1419              

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92673d1...39ccd99. Read the comment docs.

@ahrtr
Copy link
Member Author

ahrtr commented Jan 16, 2025

/test pull-etcd-robustness-arm64

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, serathius

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ahrtr
Copy link
Member Author

ahrtr commented Jan 16, 2025

Thanks @serathius for the quick review!

@ahrtr ahrtr merged commit ab819b5 into etcd-io:main Jan 16, 2025
36 checks passed
@ahrtr ahrtr deleted the migrate_command_20250116 branch January 16, 2025 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants