Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: enable thelper linter #19271

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mmorel-35
Copy link
Contributor

Description

enables and fixes thelper linter issues.

Notice that only naming rules are activated here.

Copy link

codecov bot commented Jan 25, 2025

Codecov Report

Attention: Patch coverage is 68.00000% with 8 lines in your changes missing coverage. Please review.

Project coverage is 68.83%. Comparing base (a2eedb9) to head (d05a17a).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
server/storage/wal/testing/waltesting.go 46.66% 8 Missing ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
server/storage/backend/testing/betesting.go 87.50% <100.00%> (ø)
server/storage/wal/testing/waltesting.go 60.86% <46.66%> (ø)

... and 21 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #19271      +/-   ##
==========================================
- Coverage   68.89%   68.83%   -0.07%     
==========================================
  Files         421      421              
  Lines       35897    35897              
==========================================
- Hits        24733    24711      -22     
- Misses       9740     9757      +17     
- Partials     1424     1429       +5     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a2eedb9...d05a17a. Read the comment docs.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@ahrtr ahrtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase this PR, thx

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, mmorel-35

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mmorel-35 mmorel-35 force-pushed the golangci-lint/thelper branch from 168f7db to 9f5e57e Compare January 30, 2025 22:29
@mmorel-35 mmorel-35 force-pushed the golangci-lint/thelper branch 2 times, most recently from 2e5f634 to 1adb9d7 Compare February 11, 2025 21:04
@mmorel-35 mmorel-35 force-pushed the golangci-lint/thelper branch from 1adb9d7 to 8ba65e9 Compare March 1, 2025 07:35
@mmorel-35 mmorel-35 force-pushed the golangci-lint/thelper branch from 8ba65e9 to 5bcd75f Compare March 9, 2025 18:26
@mmorel-35 mmorel-35 force-pushed the golangci-lint/thelper branch from 5bcd75f to c204f8f Compare March 15, 2025 10:46
@mmorel-35 mmorel-35 force-pushed the golangci-lint/thelper branch from c204f8f to f074e17 Compare March 15, 2025 10:49
Signed-off-by: Matthieu MOREL <[email protected]>
@mmorel-35 mmorel-35 force-pushed the golangci-lint/thelper branch from f074e17 to d05a17a Compare March 15, 2025 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants