-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
scripts/test_images.sh: refactor to import job into the prow infrastructure #19305
base: main
Are you sure you want to change the base?
Conversation
Skipping CI for Draft Pull Request. |
/test pull-etcd-release-tests |
/test pull-etcd-release-tests |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted filessee 14 files with indirect coverage changes @@ Coverage Diff @@
## main #19305 +/- ##
==========================================
- Coverage 68.84% 68.83% -0.02%
==========================================
Files 420 420
Lines 35693 35693
==========================================
- Hits 24573 24568 -5
- Misses 9698 9702 +4
- Partials 1422 1423 +1 Continue to review full report in Codecov by Sentry.
|
/test pull-etcd-release-tests |
2 similar comments
/test pull-etcd-release-tests |
/test pull-etcd-release-tests |
/test pull-etcd-release-tests |
2 similar comments
/test pull-etcd-release-tests |
/test pull-etcd-release-tests |
/test pull-etcd-release-tests |
5093328
to
e0007d7
Compare
/test pull-etcd-release-tests |
/test pull-etcd-release-tests |
/test pull-etcd-verify |
* Wrap script in functions, add a main function, and call them from it. * Make environment variables local inside the function scope to avoid unexpected behaviors by the running environment-supplied variables. * Fix the typo in the "REPOSITORY" environment variable. * Rename the input "IMAGE" to "TEST_IMAGE" to avoid clashing with the environment variable from the Prow infrastructure. Signed-off-by: Ivan Valdes <[email protected]>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ivanvc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test pull-etcd-release-tests pull-etcd-verify |
/test pull-etcd-integration-1-cpu-amd64 |
Let me know if you want me to start a fresh PR. I reused the one I used to test that the prow job worked. |
While importing the release tests into the Prow infrastructure, after some exploration, I found that the current script didn't work correctly because it allows an input environment variable "IMAGE," which in the Prow infra points to the image from the container. This made the
scripts/test_images.sh
script fail. So, I took an opportunity to rewrite the script in a more modular way while fixing this issue.Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.