Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test] Close the http response body #19308

Merged
merged 1 commit into from
Jan 30, 2025
Merged

[test] Close the http response body #19308

merged 1 commit into from
Jan 30, 2025

Conversation

ahrtr
Copy link
Member

@ahrtr ahrtr commented Jan 30, 2025

Followup of #19302

Signed-off-by: Benjamin Wang <[email protected]>
@ahrtr ahrtr changed the title Close the http response body [test] Close the http response body Jan 30, 2025
@ahrtr
Copy link
Member Author

ahrtr commented Jan 30, 2025

/test pull-etcd-unit-test-386

Copy link

codecov bot commented Jan 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.82%. Comparing base (f5973c9) to head (73700e3).
Report is 2 commits behind head on main.

Additional details and impacted files

see 21 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #19308      +/-   ##
==========================================
- Coverage   68.85%   68.82%   -0.04%     
==========================================
  Files         420      420              
  Lines       35693    35693              
==========================================
- Hits        24577    24564      -13     
- Misses       9692     9707      +15     
+ Partials     1424     1422       -2     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5973c9...73700e3. Read the comment docs.

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, serathius

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ahrtr ahrtr merged commit 488f215 into etcd-io:main Jan 30, 2025
36 checks passed
@ahrtr ahrtr deleted the http_20250130 branch January 30, 2025 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants