-
Notifications
You must be signed in to change notification settings - Fork 9.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename storageRecorder
to StorageRecorder
to fix unexported-return
lint error
#19341
Rename storageRecorder
to StorageRecorder
to fix unexported-return
lint error
#19341
Conversation
Hi @aladesawe. Thanks for your PR. I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Pulled from PR |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files
... and 17 files with indirect coverage changes @@ Coverage Diff @@
## main #19341 +/- ##
==========================================
+ Coverage 68.89% 68.94% +0.05%
==========================================
Files 420 420
Lines 35753 35753
==========================================
+ Hits 24632 24651 +19
+ Misses 9698 9681 -17
+ Partials 1423 1421 -2 Continue to review full report in Codecov by Sentry.
|
cc79a88
to
93cbf14
Compare
/ok-to-test |
Rebasing this PR might be able to resolve the workflow failure. |
Signed-off-by: adeyemi <[email protected]>
93cbf14
to
c0c9f7c
Compare
Link to issue #18370 |
storageRecorder
to StorageRecorder
to fix unexported-return
lint error
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks, @aladesawe.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahrtr, aladesawe, ivanvc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.