-
Notifications
You must be signed in to change notification settings - Fork 9.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[test] Correct the expected version in downgrade test case #19398
Conversation
ca8c5f3
to
39a0f57
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted filessee 22 files with indirect coverage changes @@ Coverage Diff @@
## main #19398 +/- ##
==========================================
- Coverage 68.95% 68.92% -0.03%
==========================================
Files 420 420
Lines 35759 35764 +5
==========================================
- Hits 24656 24652 -4
Misses 9683 9683
- Partials 1420 1429 +9 Continue to review full report in Codecov by Sentry.
|
Signed-off-by: Benjamin Wang <[email protected]>
39a0f57
to
57dc6f3
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahrtr, fuweid, henrybear327 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherry-pick release-3.6 |
@ahrtr: new pull request created: #19400 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Fix #19391
There are two issues in the existing downgrade e2e test cases:
Thanks @fuweid for the analysis.
cc @siyuanfoundation @serathius @henrybear327