Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test] Correct the expected version in downgrade test case #19398

Merged
merged 1 commit into from
Feb 12, 2025

Conversation

ahrtr
Copy link
Member

@ahrtr ahrtr commented Feb 12, 2025

Fix #19391

There are two issues in the existing downgrade e2e test cases:

  • as long as it's downgrade is enabled, then we should expect a lower cluster version.
  • after we upgrade all member to its original version, we should expect a higher cluster version.

Thanks @fuweid for the analysis.

cc @siyuanfoundation @serathius @henrybear327

@ahrtr ahrtr changed the title Correct the expected version in downgrade test case [test] Correct the expected version in downgrade test case Feb 12, 2025
@ahrtr ahrtr force-pushed the downgrade_test_20250212 branch from ca8c5f3 to 39a0f57 Compare February 12, 2025 10:58
Copy link

codecov bot commented Feb 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.92%. Comparing base (c0e7e8c) to head (57dc6f3).
Report is 2 commits behind head on main.

Additional details and impacted files

see 22 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #19398      +/-   ##
==========================================
- Coverage   68.95%   68.92%   -0.03%     
==========================================
  Files         420      420              
  Lines       35759    35764       +5     
==========================================
- Hits        24656    24652       -4     
  Misses       9683     9683              
- Partials     1420     1429       +9     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c0e7e8c...57dc6f3. Read the comment docs.

@ahrtr ahrtr force-pushed the downgrade_test_20250212 branch from 39a0f57 to 57dc6f3 Compare February 12, 2025 11:02
@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, fuweid, henrybear327

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ahrtr ahrtr merged commit f30cbaa into etcd-io:main Feb 12, 2025
38 checks passed
@ahrtr
Copy link
Member Author

ahrtr commented Feb 12, 2025

/cherry-pick release-3.6

@k8s-infra-cherrypick-robot

@ahrtr: new pull request created: #19400

In response to this:

/cherry-pick release-3.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Flaky TestDowngradeCancellationAfterDowngrading2InClusterOf3
5 participants