Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix v3.6 deprecation notices #19401

Merged
merged 3 commits into from
Feb 12, 2025
Merged

Conversation

ivanvc
Copy link
Member

@ivanvc ivanvc commented Feb 12, 2025

This pull request fixes deprecation comments in server/embed configuration options. I also did a pass to the whole repository to identify issues with deprecation comments.

From #18023 (comment).

Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.

It was pointing to ErrGRPCClusterIDMismatch rather than
ErrClusterIDMismatch.

Signed-off-by: Ivan Valdes <[email protected]>
Copy link

codecov bot commented Feb 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.87%. Comparing base (f30cbaa) to head (1f4b3cd).
Report is 4 commits behind head on main.

Additional details and impacted files
Files with missing lines Coverage Δ
api/v3rpc/rpctypes/error.go 90.47% <ø> (ø)
server/embed/config.go 80.11% <ø> (ø)
server/features/etcd_features.go 60.00% <ø> (ø)

... and 23 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #19401      +/-   ##
==========================================
- Coverage   68.91%   68.87%   -0.05%     
==========================================
  Files         420      420              
  Lines       35759    35759              
==========================================
- Hits        24645    24628      -17     
- Misses       9691     9706      +15     
- Partials     1423     1425       +2     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f30cbaa...1f4b3cd. Read the comment docs.

Copy link
Member

@ahrtr ahrtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @ivanvc for the quick fix.

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, ivanvc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ahrtr ahrtr merged commit dd6791c into etcd-io:main Feb 12, 2025
38 checks passed
@ahrtr
Copy link
Member

ahrtr commented Feb 12, 2025

/cherry-pick release-3.6

@k8s-infra-cherrypick-robot

@ahrtr: new pull request created: #19402

In response to this:

/cherry-pick release-3.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ahrtr ahrtr mentioned this pull request Feb 12, 2025
15 tasks
@ivanvc ivanvc deleted the fix-deprecation-notices branch February 12, 2025 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants