Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate --experimental-set-member-localaddr to using feature flag #19413

Merged
merged 1 commit into from
Feb 13, 2025

Migrate --experimental-set-member-localaddr to using feature flag

5fa8c1f
Select commit
Loading
Failed to load commit list.
Merged

Migrate --experimental-set-member-localaddr to using feature flag #19413

Migrate --experimental-set-member-localaddr to using feature flag
5fa8c1f
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Feb 13, 2025 in 1s

68.95% (+0.00%) compared to 3bd966d

View this Pull Request on Codecov

68.95% (+0.00%) compared to 3bd966d

Details

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.95%. Comparing base (3bd966d) to head (5fa8c1f).
Report is 2 commits behind head on main.

Additional details and impacted files
Files with missing lines Coverage Δ
server/embed/config.go 80.08% <100.00%> (-0.03%) ⬇️
server/embed/etcd.go 76.32% <ø> (-0.05%) ⬇️
server/features/etcd_features.go 60.00% <ø> (ø)

... and 26 files with indirect coverage changes

@@           Coverage Diff           @@
##             main   #19413   +/-   ##
=======================================
  Coverage   68.95%   68.95%           
=======================================
  Files         420      420           
  Lines       35755    35753    -2     
=======================================
- Hits        24656    24655    -1     
- Misses       9677     9680    +3     
+ Partials     1422     1418    -4     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3bd966d...5fa8c1f. Read the comment docs.