-
Notifications
You must be signed in to change notification settings - Fork 9.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-3.6] Fix release script prerelease GitHub template release #19420
[release-3.6] Fix release script prerelease GitHub template release #19420
Conversation
The GitHub release templates had the wrong version minor when there's a prerelease part in the version (i.e., v3.6.0-rc.0). It cut until the last dot, leaving a wrong minor version (i.e., v3.6.0-rc). Signed-off-by: Ivan Valdes <[email protected]>
Signed-off-by: Ivan Valdes <[email protected]>
Hi @k8s-infra-cherrypick-robot. Thanks for your PR. I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/test pull-etcd-grpcproxy-integration-amd64 pull-etcd-grpcproxy-integration-arm64 pull-etcd-grpcproxy-integration-arm64 pull-etcd-grpcproxy-e2e-arm64 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted filessee 25 files with indirect coverage changes @@ Coverage Diff @@
## release-3.6 #19420 +/- ##
===============================================
- Coverage 68.95% 68.82% -0.13%
===============================================
Files 420 420
Lines 35753 35753
===============================================
- Hits 24652 24607 -45
- Misses 9676 9718 +42
- Partials 1425 1428 +3 Continue to review full report in Codecov by Sentry.
|
/ok-to-test |
/test pull-etcd-grpcproxy-integration-amd64 pull-etcd-grpcproxy-integration-arm64 pull-etcd-grpcproxy-integration-arm64 pull-etcd-grpcproxy-e2e-arm64 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM on green.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahrtr, ivanvc, k8s-infra-cherrypick-robot The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
This is an automated cherry-pick of #19418
/assign ivanvc