Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github/workflows: remove contrib workflow #19421

Merged
merged 1 commit into from
Feb 16, 2025

Conversation

ivanvc
Copy link
Member

@ivanvc ivanvc commented Feb 14, 2025

This job is already running in the Prow infrastructure.

After merging kubernetes/test-infra#34335 it will be blocking, so we can remove this workflow.

Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.

This job is already running in the Prow infrastructure.

Signed-off-by: Ivan Valdes <[email protected]>
@k8s-ci-robot k8s-ci-robot added github_actions Pull requests that update GitHub Actions code approved size/S labels Feb 14, 2025
Copy link

codecov bot commented Feb 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.95%. Comparing base (14cf669) to head (0bbc42a).
Report is 4 commits behind head on main.

Additional details and impacted files

see 20 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #19421      +/-   ##
==========================================
- Coverage   68.95%   68.95%   -0.01%     
==========================================
  Files         420      420              
  Lines       35753    35753              
==========================================
- Hits        24655    24654       -1     
+ Misses       9677     9673       -4     
- Partials     1421     1426       +5     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14cf669...0bbc42a. Read the comment docs.

@ivanvc
Copy link
Member Author

ivanvc commented Feb 16, 2025

/retest

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, fuweid, ivanvc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ahrtr ahrtr merged commit eb7607b into etcd-io:main Feb 16, 2025
42 checks passed
@ivanvc ivanvc deleted the remove-contrib-mixin-github-workflow branch February 20, 2025 07:13
@ivanvc
Copy link
Member Author

ivanvc commented Mar 7, 2025

/cherry-pick release-3.6

@k8s-infra-cherrypick-robot

@ivanvc: new pull request created: #19549

In response to this:

/cherry-pick release-3.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved github_actions Pull requests that update GitHub Actions code size/S
Development

Successfully merging this pull request may close these issues.

5 participants