github/workflows: remove coverage workflow #19424
Conversation
This workflow has already been migrated to the Prow infrastructure. Signed-off-by: Ivan Valdes <[email protected]>
|
Skipping CI for Draft Pull Request. |
k8s-ci-robot
added
do-not-merge/work-in-progress
github_actions
|
/test all |
|
/test pull-etcd-coverage-report |
1 similar comment
|
/test pull-etcd-coverage-report |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted filessee 56 files with indirect coverage changes @@ Coverage Diff @@
## main #19424 +/- ##
==========================================
+ Coverage 68.95% 69.50% +0.54%
==========================================
Files 420 406 -14
Lines 35753 35432 -321
==========================================
- Hits 24655 24628 -27
+ Misses 9677 9388 -289
+ Partials 1421 1416 -5 Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
ivanvc
force-pushed
the
remove-codecov-github-workflow
branch
from
1651346 to
5bb5f28
Compare
ivanvc
changed the title
ivanvc
force-pushed
the
remove-codecov-github-workflow
branch
from
5bb5f28 to
7d87198
Compare
Signed-off-by: Ivan Valdes <[email protected]>
ivanvc
force-pushed
the
remove-codecov-github-workflow
branch
from
7d87198 to
4ce48ce
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahrtr, ivanvc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
|
@ahrtr, could we get this merged? Or do we want/need a second reviewer? |
| bash ./bin/codecov.sh -f "${COVERDIR}/all.coverprofile" \ | ||
| -cF all \ | ||
| -C "${PULL_PULL_SHA}" \ | ||
| -r "${REPO_OWNER}/${REPO_NAME}" \ | ||
| -P "${PULL_NUMBER}" \ | ||
| -b "${BUILD_ID}" \ | ||
| -B "${PULL_BASE_REF}" \ | ||
| -N "${PULL_BASE_SHA}" |
There was a problem hiding this comment.
This seems to be an unrelated enhancement. It would be better to do it separately. But I won't insist on it.
There was a problem hiding this comment.
It's not unrelated because we will publish the reports from the Prow job; we need to specify these variables/arguments. In the GitHub actions environment, CodeCov would assume these values.
This workflow has already been migrated to the Prow infrastructure.
To have the Codecov bot publish the coverage report from the given pull request, it must be invoked using some additional arguments.
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.