feat(test/robustness): Utilize Porcupine linearization for watch validation #19428
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: iamrajiv The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Hi @iamrajiv. Thanks for your PR. I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
- Add getLinearizedRequests function to preserve error responses during replay - Modify ValidateAndReturnVisualize to use linearized operations - Ensure failed operations are correctly positioned in the replay sequence
- Introduce new error `errBrokeLinearizable` to detect watch events that violate linearization order - Enhance watch validation robustness by tracking potential linearizability issues
- Introduce new test cases to validate linearizability of watch events
| @@ -54,6 +55,41 @@ func ValidateAndReturnVisualize(t *testing.T, lg *zap.Logger, cfg Config, report | |||
| return results | |||
| } | |||
|
|
|||
| // getLinearizedRequests converts linearizable operations to a sequence of requests | |||
| // while preserving error responses from the client reports | |||
| func getLinearizedRequests(operations []porcupine.Operation, reports []report.ClientReport, persistedRequests []model.EtcdRequest) []model.EtcdRequest { | |||
There was a problem hiding this comment.
Don't think you understood the task, the goal was to read linearization results, not linearization operations.
Fixes: #19088