-
Notifications
You must be signed in to change notification settings - Fork 10k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[2025-02-22] Bump dependency updates identified by dependabot #19466
Conversation
@ivanvc there are quite some linter errors after bumping the dependency this time. Should I address all of them also in this PR? |
I reviewed them, and addressing them sounds easy. However, it's going to be a lengthier pull request. I think we should do that in a new pull request first, then rebase this pull request after we merge. |
Please fix the workflow failures. thx |
5f1816e
to
a731928
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted filessee 24 files with indirect coverage changes @@ Coverage Diff @@
## main #19466 +/- ##
==========================================
- Coverage 68.87% 68.86% -0.02%
==========================================
Files 420 420
Lines 35779 35762 -17
==========================================
- Hits 24642 24626 -16
Misses 9711 9711
+ Partials 1426 1425 -1 Continue to review full report in Codecov by Sentry.
|
a731928
to
916d0dd
Compare
Please rebase this PR, thx |
Reference: - etcd-io#19438 Signed-off-by: Chun-Hung Tseng <[email protected]>
…ng.org/x/net from 0.34.0 to 0.35.0 Reference: - etcd-io#19434 = etcd-io#19437 Signed-off-by: Chun-Hung Tseng <[email protected]>
….4.0 Reference: - etcd-io#19436 Signed-off-by: Chun-Hung Tseng <[email protected]>
Reference: - etcd-io#19435 Signed-off-by: Chun-Hung Tseng <[email protected]>
916d0dd
to
6784151
Compare
Done |
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks, @henrybear327.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahrtr, henrybear327, ivanvc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.
This pull request completes this week's etcd dependency updates following our dependency roster and dependency management instructions.
Summary of actions
Bumped
Fully indirect
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.