Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2025-02-22] Bump dependency updates identified by dependabot #19466

Merged
merged 4 commits into from
Feb 25, 2025

Conversation

@henrybear327
Copy link
Contributor Author

@henrybear327: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-etcd-verify 5f1816e link true /test pull-etcd-verify
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

@ivanvc there are quite some linter errors after bumping the dependency this time. Should I address all of them also in this PR?

@ivanvc
Copy link
Member

ivanvc commented Feb 22, 2025

@ivanvc there are quite some linter errors after bumping the dependency this time. Should I address all of them also in this PR?

I reviewed them, and addressing them sounds easy. However, it's going to be a lengthier pull request. I think we should do that in a new pull request first, then rebase this pull request after we merge.

@ahrtr
Copy link
Member

ahrtr commented Feb 24, 2025

Please fix the workflow failures. thx

Copy link

codecov bot commented Feb 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.86%. Comparing base (8e44d3a) to head (6784151).
Report is 5 commits behind head on main.

Additional details and impacted files

see 24 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #19466      +/-   ##
==========================================
- Coverage   68.87%   68.86%   -0.02%     
==========================================
  Files         420      420              
  Lines       35779    35762      -17     
==========================================
- Hits        24642    24626      -16     
  Misses       9711     9711              
+ Partials     1426     1425       -1     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e44d3a...6784151. Read the comment docs.

@henrybear327
Copy link
Contributor Author

Rebased this PR on #19475 to resolve CI issues

cc: @ahrtr @ivanvc

@ahrtr
Copy link
Member

ahrtr commented Feb 25, 2025

Please rebase this PR, thx

@henrybear327
Copy link
Contributor Author

Please rebase this PR, thx

Done

@henrybear327
Copy link
Contributor Author

/retest

Copy link
Member

@ahrtr ahrtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thank you!

Copy link
Member

@ivanvc ivanvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @henrybear327.

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, henrybear327, ivanvc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ahrtr ahrtr merged commit 78a7ca6 into etcd-io:main Feb 25, 2025
41 checks passed
@henrybear327 henrybear327 deleted the dependency/2025_02_22 branch March 12, 2025 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants