Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-3.6] Fix TestLeaseGrantTimeToLiveExpired flaky due to leader change #19481

Merged
merged 1 commit into from
Feb 25, 2025

Conversation

ahrtr
Copy link
Member

@ahrtr ahrtr commented Feb 25, 2025

Backport #19476 to 3.6

@ahrtr
Copy link
Member Author

ahrtr commented Feb 25, 2025

We need at least one maintainer to approve. @jmhbnz

Copy link

codecov bot commented Feb 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.86%. Comparing base (efcf06a) to head (6662b3c).
Report is 2 commits behind head on release-3.6.

Additional details and impacted files

see 26 files with indirect coverage changes

@@               Coverage Diff               @@
##           release-3.6   #19481      +/-   ##
===============================================
- Coverage        68.93%   68.86%   -0.07%     
===============================================
  Files              420      420              
  Lines            35762    35762              
===============================================
- Hits             24651    24628      -23     
- Misses            9688     9708      +20     
- Partials          1423     1426       +3     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update efcf06a...6662b3c. Read the comment docs.

Copy link
Member

@ivanvc ivanvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This backport looks correct.

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, ivanvc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ahrtr ahrtr merged commit 22f450a into etcd-io:release-3.6 Feb 25, 2025
39 checks passed
@ivanvc ivanvc mentioned this pull request Feb 25, 2025
2 tasks
@ivanvc
Copy link
Member

ivanvc commented Feb 25, 2025

/retitle [release-3.6] Fix TestLeaseGrantTimeToLiveExpired flaky due to leader change

@k8s-ci-robot k8s-ci-robot changed the title [3.6] Fix TestLeaseGrantTimeToLiveExpired flaky due to leader change [release-3.6] Fix TestLeaseGrantTimeToLiveExpired flaky due to leader change Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants