Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-3.6] Fix flaky TestLeaseKeepAliveOneSecond #19483

Conversation

k8s-infra-cherrypick-robot

This is an automated cherry-pick of #19473

/assign ahrtr

@k8s-ci-robot
Copy link

Hi @k8s-infra-cherrypick-robot. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ahrtr
Copy link
Member

ahrtr commented Feb 25, 2025

/ok-to-test

@ahrtr
Copy link
Member

ahrtr commented Feb 25, 2025

Recently I frequently see error like below, it seems that the test-infra has very limited resource/runners? cc @ivanvc @jmhbnz

Test started today at 6:24 PM failed after 5m0s. ([more info](https://prow.k8s.io/spyglass/lens/metadata/iframe?req=%7B%22artifacts%22%3A%5B%22finished.json%22%2C%22podinfo.json%22%2C%22prowjob.json%22%2C%22started.json%22%5D%2C%22index%22%3A0%2C%22src%22%3A%22gs%2Fkubernetes-ci-logs%2Fpr-logs%2Fpull%2Fetcd-io_etcd%2F19483%2Fpull-etcd-grpcproxy-integration-arm64%2F1894453371314638848%22%7D&topURL=https%3A//prow.k8s.io/view/gs/kubernetes-ci-logs/pr-logs/pull/etcd-io_etcd/19483/pull-etcd-grpcproxy-integration-arm64/1894453371314638848&lensIndex=0#))

There are no nodes that your pod can schedule to - check your requests, tolerations, and node selectors (skip schedule deleting pod: test-pods/39a837cb-741d-4144-b0f3-5c16884d2775)

@ahrtr
Copy link
Member

ahrtr commented Feb 25, 2025

/retest

Copy link

codecov bot commented Feb 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.93%. Comparing base (22f450a) to head (6921983).
Report is 2 commits behind head on release-3.6.

Additional details and impacted files

see 24 files with indirect coverage changes

@@               Coverage Diff               @@
##           release-3.6   #19483      +/-   ##
===============================================
+ Coverage        68.92%   68.93%   +0.01%     
===============================================
  Files              420      420              
  Lines            35762    35779      +17     
===============================================
+ Hits             24649    24665      +16     
- Misses            9689     9691       +2     
+ Partials          1424     1423       -1     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 22f450a...6921983. Read the comment docs.

@ivanvc
Copy link
Member

ivanvc commented Feb 25, 2025

Recently I frequently see error like below, it seems that the test-infra has very limited resource/runners? cc @ivanvc @jmhbnz

Maybe we onboarded too many of our jobs, and now we have a significant footprint in the infra. We should reach out to sig-testing.

Copy link
Member

@ivanvc ivanvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ivanvc, k8s-infra-cherrypick-robot
Once this PR has been reviewed and has the lgtm label, please ask for approval from ahrtr. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ahrtr ahrtr merged commit b9d33a2 into etcd-io:release-3.6 Feb 25, 2025
39 checks passed
@ivanvc ivanvc mentioned this pull request Feb 25, 2025
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants