-
Notifications
You must be signed in to change notification settings - Fork 10k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add release date for v3.4.36
and v3.6.0-rc.1
#19484
Conversation
Signed-off-by: James Blair <[email protected]>
Signed-off-by: James Blair <[email protected]>
@@ -8,7 +8,11 @@ Previous change logs can be found at [CHANGELOG-3.5](https://github.com/etcd-io/ | |||
|
|||
<hr> | |||
|
|||
## v3.6.0-rc.1 (TBD) | |||
## v3.6.0-rc.2 (TBD) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added this placeholder but we can just delete it if we decide to publish v3.6.0
without an rc2 release.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need rc.2 because we need to backport #19452
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's target rc.2 next week.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted filessee 20 files with indirect coverage changes @@ Coverage Diff @@
## main #19484 +/- ##
==========================================
+ Coverage 68.82% 68.84% +0.02%
==========================================
Files 420 420
Lines 35762 35779 +17
==========================================
+ Hits 24613 24632 +19
+ Misses 9719 9717 -2
Partials 1430 1430 Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks, James.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahrtr, ivanvc, jmhbnz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Both releases were published successfully during today's release meeting.
cc @ivanvc, @ahrtr