-
Notifications
You must be signed in to change notification settings - Fork 9.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add e2e test to reproduce issue #19406 #19608
base: main
Are you sure you want to change the base?
Conversation
Hi @miancheng7. Thanks for your PR. I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
8f102c6
to
320b1b0
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
... and 26 files with indirect coverage changes @@ Coverage Diff @@
## main #19608 +/- ##
==========================================
+ Coverage 68.76% 68.85% +0.08%
==========================================
Files 421 421
Lines 35897 35897
==========================================
+ Hits 24686 24717 +31
+ Misses 9783 9752 -31
Partials 1428 1428 Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
/ok-to-test |
t.Cleanup(func() { require.NoError(t, clus.Stop()) }) | ||
|
||
// produce some data | ||
cli := newClient(t, clus.EndpointsGRPC(), e2e.ClientConfig{}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can reuse the v3 client in generateTrafficAndVerifyPutLatency
?
320b1b0
to
16dc8de
Compare
8c4d3fc
to
8563cb0
Compare
Signed-off-by: Miancheng Lin <[email protected]>
8563cb0
to
9507b5d
Compare
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: chaochn47, miancheng7 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
cc @ahrtr @serathius @fuweid for a stamp of approval, thanks! |
PR Description
This is a follow-up to issue #19406.
The fix in #19405 has been merged, and this PR introduces an e2e test to reproduce the issue. The goal is to ensure that the test will catch the problem if it resurfaces in the future.
Testing
I have tested this locally and confirmed that the test:
✅ Passes consistently with the fix applied.
❌ Fails reliably if the fix in #19405 is rolled back.
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.