Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use testify instead of testing in tests/integration #19616

Merged
merged 1 commit into from
Mar 24, 2025

Conversation

mmorel-35
Copy link
Contributor

Description

This uses testify instead of testing for t.Fatal or t.Error calls in tests/integration package

Related to #18972

@mmorel-35 mmorel-35 force-pushed the testifier/tests/integration branch from a9b0683 to ef4b176 Compare March 15, 2025 17:41
@mmorel-35 mmorel-35 force-pushed the testifier/tests/integration branch 2 times, most recently from b1ca9fc to 61a0086 Compare March 15, 2025 18:12
@mmorel-35 mmorel-35 force-pushed the testifier/tests/integration branch from 61a0086 to d05b8b7 Compare March 15, 2025 18:29
Copy link

codecov bot commented Mar 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.86%. Comparing base (f07e2ae) to head (d05b8b7).
Report is 40 commits behind head on main.

Additional details and impacted files

see 26 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #19616      +/-   ##
==========================================
+ Coverage   68.77%   68.86%   +0.08%     
==========================================
  Files         421      421              
  Lines       35897    35897              
==========================================
+ Hits        24689    24721      +32     
+ Misses       9786     9748      -38     
- Partials     1422     1428       +6     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f07e2ae...d05b8b7. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, fuweid, mmorel-35

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ahrtr ahrtr merged commit 1db0fc5 into etcd-io:main Mar 24, 2025
33 checks passed
@mmorel-35 mmorel-35 deleted the testifier/tests/integration branch March 24, 2025 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants