[release-3.6] Auto sync members in v3store is IsLearner differs between v2 and v3 store

[ahrtr]

release-3.6 isn't able to automatically fix the issues which have already been affected by #19557.

Also adding the validation has flaws as mentioned in #19557 (comment)

Eventually I tried to add similar auto sync in 3.6 as what we did for 3.5 in #19606

This is the only way to avoid all confusion and reduce of user experience.

cc @fuweid @serathius @siyuanfoundation

[codecov]

Codecov Report

Attention: Patch coverage is 54.90196% with 23 lines in your changes missing coverage. Please review.

Project coverage is 68.98%. Comparing base (f9df7c6) to head (de774e7).
Report is 4 commits behind head on release-3.6.

Files with missing lines	Patch %	Lines
server/etcdserver/api/membership/cluster.go	69.23%	11 Missing and 1 partial ⚠️
server/storage/schema/membership.go	0.00%	9 Missing ⚠️
server/storage/backend/verify.go	0.00%	1 Missing and 1 partial ⚠️

Additional details and impacted files

Files with missing lines	Coverage Δ
server/etcdserver/api/membership/store.go	60.00% <ø> (ø)
server/etcdserver/bootstrap.go	63.67% <100.00%> (+0.08%)	⬆️
server/storage/backend/verify.go	84.61% <0.00%> (-3.39%)	⬇️
server/storage/schema/membership.go	56.16% <0.00%> (-3.69%)	⬇️
server/etcdserver/api/membership/cluster.go	87.29% <69.23%> (-1.31%)	⬇️

... and 25 files with indirect coverage changes

@@               Coverage Diff               @@
##           release-3.6   #19636      +/-   ##
===============================================
+ Coverage        68.87%   68.98%   +0.11%     
===============================================
  Files              420      420              
  Lines            35787    35827      +40     
===============================================
+ Hits             24648    24717      +69     
+ Misses            9705     9689      -16     
+ Partials          1434     1421      -13     

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9df7c6...de774e7. Read the comment docs.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[siyuanfoundation]

/lgtm

[fuweid]

LGTM

[k8s-ci-robot]

New changes are detected. LGTM label has been removed.

[ahrtr]

cc @siyuanfoundation @serathius

[serathius]

release-3.6 isn't able to automatically fix the issues which have already been affected by #19557.

What do you mean by that?

[serathius]

Left couple of comments apart of that LGTM.

[ahrtr]

release-3.6 isn't able to automatically fix the issues which have already been affected by #19557.

What do you mean by that?

release-3.5 is able to automatically fix the already affected issues after #19602. But release-3.6 isn't able to automatically fix it, see #19557 (comment)

It's exactly the reason why we need this PR.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, fuweid, serathius

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [ahrtr,serathius]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment