Skip to content

Comments

Antithesis Integration: Move Antithesis demo to etcd repo#19739

Merged
serathius merged 1 commit intoetcd-io:mainfrom
abdurrehman107:abdur-rehman/antithesis-integration
Apr 14, 2025
Merged

Antithesis Integration: Move Antithesis demo to etcd repo#19739
serathius merged 1 commit intoetcd-io:mainfrom
abdurrehman107:abdur-rehman/antithesis-integration

Conversation

@abdurrehman107
Copy link
Member

This PR moves parts of the demo to the etcd repo. I've also run the tests locally and setup a demo cluster using docker-compose.
cc @serathius

@codecov
Copy link

codecov bot commented Apr 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.81%. Comparing base (0ad7ea4) to head (a730bbd).
Report is 8 commits behind head on main.

Additional details and impacted files

see 151 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #19739      +/-   ##
==========================================
+ Coverage   61.96%   68.81%   +6.84%     
==========================================
  Files         406      421      +15     
  Lines       34632    35857    +1225     
==========================================
+ Hits        21461    24674    +3213     
+ Misses      11595     9753    -1842     
+ Partials     1576     1430     -146     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ad7ea4...a730bbd. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@abdurrehman107 abdurrehman107 force-pushed the abdur-rehman/antithesis-integration branch 2 times, most recently from cf3c554 to da055ae Compare April 12, 2025 15:41
@henrybear327
Copy link
Contributor

/ok-to-test

@abdurrehman107 abdurrehman107 force-pushed the abdur-rehman/antithesis-integration branch from 7819ee0 to 3b4f94e Compare April 14, 2025 07:28
@abdurrehman107
Copy link
Member Author

Addressed comments team. Can we please review again?
cc @serathius @henrybear327

@abdurrehman107 abdurrehman107 force-pushed the abdur-rehman/antithesis-integration branch from 3b4f94e to 4e3051a Compare April 14, 2025 08:11
@serathius
Copy link
Member

Please fix:

./tests/antithesis/docker-compose.yaml
  1:1       warning  missing document start "---"  (document-start)
  7:17      error    trailing spaces  (trailing-spaces)
  22:17     error    trailing spaces  (trailing-spaces)
  37:17     error    trailing spaces  (trailing-spaces)
  51:35     error    no new line character at the end of file  (new-line-at-end-of-file)

@henrybear327
Copy link
Contributor

Addressed comments team. Can we please review again? cc @serathius @henrybear327

Please fix linter errors, thank you!

./tests/antithesis/docker-compose.yaml
  1:1       warning  missing document start "---"  (document-start)
  7:17      error    trailing spaces  (trailing-spaces)
  22:17     error    trailing spaces  (trailing-spaces)
  37:17     error    trailing spaces  (trailing-spaces)
  51:35     error    no new line character at the end of file  (new-line-at-end-of-file)

Copy link
Contributor

@henrybear327 henrybear327 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing the initial comments! :)

Signed-off-by: Abdur Rehman <razashahid107@gmail.com>
@abdurrehman107 abdurrehman107 force-pushed the abdur-rehman/antithesis-integration branch from c6e4157 to a730bbd Compare April 14, 2025 14:30
@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abdurrehman107, serathius

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@serathius serathius merged commit 4b7e512 into etcd-io:main Apr 14, 2025
30 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

4 participants