Skip to content

Combine common txn arguments into TxnContext #19809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

serathius
Copy link
Member

Copy link

codecov bot commented Apr 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.79%. Comparing base (e271b78) to head (23baf83).
Report is 227 commits behind head on main.

Additional details and impacted files
Files with missing lines Coverage Δ
server/etcdserver/apply/apply.go 77.72% <100.00%> (+0.62%) ⬆️
server/etcdserver/txn/txn.go 93.73% <100.00%> (ø)
server/etcdserver/v3_server.go 75.16% <100.00%> (+1.43%) ⬆️

... and 24 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #19809      +/-   ##
==========================================
- Coverage   68.86%   68.79%   -0.08%     
==========================================
  Files         421      421              
  Lines       35867    35884      +17     
==========================================
- Hits        24700    24686      -14     
- Misses       9745     9772      +27     
- Partials     1422     1426       +4     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 021aece...23baf83. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@serathius serathius force-pushed the refactor-txn-context branch from f3c78cc to 23baf83 Compare April 29, 2025 15:18
@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fuweid, serathius

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

TxnModeWriteWithSharedBuffer bool
}

func Put(ctx context.Context, txn TxnContext, p *pb.PutRequest) (resp *pb.PutResponse, trace *traceutil.Trace, err error) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: how about renaming txn to txnContext? because txn is usually short for transaction, which it is not.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SG

@serathius serathius marked this pull request as draft May 6, 2025 07:16
@k8s-ci-robot
Copy link

@serathius: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci-etcd-robustness-release36-amd64 23baf83 link true /test ci-etcd-robustness-release36-amd64
ci-etcd-robustness-release35-amd64 23baf83 link true /test ci-etcd-robustness-release35-amd64

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants