-
Notifications
You must be signed in to change notification settings - Fork 10.1k
[release-3.5] Backport Deprecated Metadata field in Endpoint struct #19846
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
resolves: etcd-io#19706 Signed-off-by: amosehiguese <[email protected]>
Hi @amosehiguese. Thanks for your PR. I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test Does it make sense to deprecate backwards (or, in other words, backport this deprecation)? |
Link to #19706 |
"backport this deprecation" would be the right way to put it. Thank you for the correction |
/retitle [release 3.5] Backport Deprecated Metadata field in Endpoint struct |
@amosehiguese: Re-titling can only be requested by trusted users, like repository collaborators. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM & thx
Yes, I think so. We should discourage users to use it as earlier as possible. |
backport of #19825 |
Do you need me to fix something? @ahrtr |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahrtr, amosehiguese, fuweid The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retitle [release-3.5] Backport Deprecated Metadata field in Endpoint struct |
This PR cherry-picks commit
28d10d35c07d4fe9faf84e4bf63aa79385c1a821
frommain
into therelease-3.5
branch.cc: @ahrtr
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.