Skip to content

[release-3.5] Backport Deprecated Metadata field in Endpoint struct #19846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 5, 2025

Conversation

amosehiguese
Copy link
Contributor

@amosehiguese amosehiguese commented Apr 30, 2025

This PR cherry-picks commit 28d10d35c07d4fe9faf84e4bf63aa79385c1a821 from main into the release-3.5 branch.

cc: @ahrtr

Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.

@k8s-ci-robot
Copy link

Hi @amosehiguese. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ivanvc
Copy link
Member

ivanvc commented Apr 30, 2025

/ok-to-test

Does it make sense to deprecate backwards (or, in other words, backport this deprecation)?

@ivanvc
Copy link
Member

ivanvc commented Apr 30, 2025

Link to #19706

@amosehiguese
Copy link
Contributor Author

/ok-to-test

Does it make sense to deprecate backwards (or, in other words, backport this deprecation)?

"backport this deprecation" would be the right way to put it.

Thank you for the correction

@amosehiguese
Copy link
Contributor Author

/retitle [release 3.5] Backport Deprecated Metadata field in Endpoint struct

@k8s-ci-robot
Copy link

@amosehiguese: Re-titling can only be requested by trusted users, like repository collaborators.

In response to this:

/retitle [release 3.5] Backport Deprecated Metadata field in Endpoint struct

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@amosehiguese amosehiguese changed the title [release 3.5] Deprecate Metadata field in Endpoint struct [release 3.5] Backport Deprecated Metadata field in Endpoint struct Apr 30, 2025
Copy link
Member

@ahrtr ahrtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM & thx

@ahrtr
Copy link
Member

ahrtr commented May 1, 2025

Does it make sense to deprecate backwards (or, in other words, backport this deprecation)?

Yes, I think so. We should discourage users to use it as earlier as possible.

@ahrtr ahrtr requested review from ivanvc and jmhbnz May 1, 2025 10:10
@ahrtr
Copy link
Member

ahrtr commented May 1, 2025

backport of #19825

@amosehiguese
Copy link
Contributor Author

Do you need me to fix something? @ahrtr

@ahrtr
Copy link
Member

ahrtr commented May 1, 2025

Do you need me to fix something? @ahrtr

Usually we need two approval to merge a PR. cc @ivanvc @jmhbnz

@jmhbnz jmhbnz requested a review from serathius May 3, 2025 10:32
@ahrtr ahrtr requested a review from fuweid May 5, 2025 09:50
@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, amosehiguese, fuweid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ahrtr ahrtr merged commit 104e245 into etcd-io:release-3.5 May 5, 2025
27 checks passed
@ivanvc
Copy link
Member

ivanvc commented May 5, 2025

/retitle [release-3.5] Backport Deprecated Metadata field in Endpoint struct

@k8s-ci-robot k8s-ci-robot changed the title [release 3.5] Backport Deprecated Metadata field in Endpoint struct [release-3.5] Backport Deprecated Metadata field in Endpoint struct May 5, 2025
@amosehiguese amosehiguese deleted the release-3.5-fix branch May 5, 2025 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

5 participants