chore(CHANGELOG): update v3.5 and v3.6 changelog to reflect Endpoint.Metadata deprecation #19847
Conversation
|
Hi @amosehiguese. Thanks for your PR. I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
CHANGELOG/CHANGELOG-3.5.md
Outdated
| @@ -6,6 +6,10 @@ Previous change logs can be found at [CHANGELOG-3.4](https://github.com/etcd-io/ | |||
|
|
|||
| ## v3.5.22 (TBC) | |||
|
|
|||
| ### Deprecations | |||
|
|
|||
| - [Deprecated the Metadata field in the Endpoint struct from the client/v3/naming/endpoints package ](https://github.com/etcd-io/etcd/pull/19846). | |||
There was a problem hiding this comment.
Please move this to the section "Package clientv3".
CHANGELOG/CHANGELOG-3.6.md
Outdated
| @@ -10,6 +10,10 @@ Previous change logs can be found at [CHANGELOG-3.5](https://github.com/etcd-io/ | |||
|
|
|||
| ## v3.6.0-rc.5 (tbd) | |||
|
|
|||
| ### Deprecations | |||
|
|
|||
| - [Deprecated the Metadata field in the Endpoint struct from the client/v3/naming/endpoints package ](https://github.com/etcd-io/etcd/pull/19842). | |||
There was a problem hiding this comment.
Please move this to the section "Package clientv3".
amosehiguese
force-pushed
the
update-changelog
branch
from
ee3171e to
bbd24e0
Compare
CHANGELOG/CHANGELOG-3.6.md
Outdated
| @@ -18,6 +18,8 @@ Previous change logs can be found at [CHANGELOG-3.5](https://github.com/etcd-io/ | |||
|
|
|||
| - [Replace `resolver.State.Addresses` with `resolver.State.Endpoint.Addresses`](https://github.com/etcd-io/etcd/pull/19782). | |||
|
|
|||
CHANGELOG/CHANGELOG-3.5.md
Outdated
| @@ -14,6 +14,8 @@ Previous change logs can be found at [CHANGELOG-3.4](https://github.com/etcd-io/ | |||
|
|
|||
| - [Replace `resolver.State.Addresses` with `resolver.State.Endpoint.Addresses`](https://github.com/etcd-io/etcd/pull/19783). | |||
|
|
|||
…Metadata deprecation Signed-off-by: amosehiguese <[email protected]>
amosehiguese
force-pushed
the
update-changelog
branch
from
bbd24e0 to
965603e
Compare
|
/ok-to-test |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted filessee 48 files with indirect coverage changes @@ Coverage Diff @@
## main #19847 +/- ##
==========================================
+ Coverage 67.56% 68.80% +1.24%
==========================================
Files 424 424
Lines 35862 35862
==========================================
+ Hits 24231 24676 +445
+ Misses 10208 9760 -448
- Partials 1423 1426 +3 Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahrtr, amosehiguese, fuweid The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This PR updates the v3.5 and v3.6 changelog entries to include a deprecation notice for the
Metadatafield in theEndpointstruct from theclient/v3/naming/endpointspackage.cc: @ahrtr @ivanvc
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.